[PATCH] add RTC 8564 I2C chip support

[s***@eletztrick.de]

Hi,
the attached patch adds support for the Epson 8564 RTC
chip. This chip is a generic real-time-clock sitting on
a I2C bus.

Patch URL:
http://213.239.196.168/~seletz/patches/2.6.6-rc2/i2c-rtc8564.patch

Please comment,
Stefan E.

[s***@eletztrick.de]

Post by s***@eletztrick.de
Hi,
the attached patch adds support for the Epson 8564 RTC
chip. This chip is a generic real-time-clock sitting on
a I2C bus.

Duh, it's against 2.6.6-rc2 :)

Post by s***@eletztrick.de
http://213.239.196.168/~seletz/patches/2.6.6-rc2/i2c-rtc8564.patch
Please comment,
Stefan E.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

[Florian Schirmer]

Hi,

FYI alle deine Mails kommen immer 2x auf der LKML an. Solltest du mal bei
Gelegenheit untersuchen. Mir ists egal aber es gibt immer ein paar Dödel die
dann nichts besseres zu tun haben als sich zu Ärgern ;-)

Grüsse,
Florian

Post by s***@eletztrick.de
Hi,
the attached patch adds support for the Epson 8564 RTC
chip. This chip is a generic real-time-clock sitting on
a I2C bus.
http://213.239.196.168/~seletz/patches/2.6.6-rc2/i2c-rtc8564.patch
Please comment,
Stefan E.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

[Jean Delvare]

Hi Stefan,

Just a quick comment about your patch: it's a common habit of the
sensors folks to prefix i2c bus drivers with i2c-, but not chip
drivers. So I would suggest that you name your driver rtc8564, not
i2c-rtc8564.

Also, please keep the lines in drivers/i2c/chips/Makefile in the
alphabetic order. And your header states
"linux/drivers/system3/rtc8564.c" while the driver will be in a
different location. Please correct.

I've not read your code otherwise, I don't know anything about RTCs.

Thanks.

[s***@eletztrick.de]

Post by Jean Delvare
Hi Stefan,
Just a quick comment about your patch: it's a common habit of the
sensors folks to prefix i2c bus drivers with i2c-, but not chip
drivers. So I would suggest that you name your driver rtc8564, not
i2c-rtc8564.

Ok, I'll fix that.

Post by Jean Delvare
Also, please keep the lines in drivers/i2c/chips/Makefile in the
alphabetic order.

... and that one

Post by Jean Delvare
And your header states
"linux/drivers/system3/rtc8564.c" while the driver will be in a
different location. Please correct.

And that too.

Post by Jean Delvare
I've not read your code otherwise, I don't know anything about RTCs.
Thanks.
--
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

[s***@eletztrick.de]

Hi,
here's a updated patch which adds support for the RTC
8564 Chip from Epson. This is a RTC chip sitting on a
I2C bus.

The patch is against 2.6.6-rc3.

I've removed the "i2c-" part of the file names, and updated
the comments in the file headers.

The Makefile is now kept sorted, too.

Please comment,
Stefan E.

Patch URL:
http://213.239.196.168/~seletz/patches/2.6.6-rc2/i2c-rtc8564.patch