Discussion:
[PATCH] Staging: drm_gem: Fix a misaligned comment block
(too old to reply)
Igor Matheus Andrade Torrente
2020-03-16 21:15:53 UTC
Permalink
Fix a checkpatch warning caused by a misaligned comment block.

Signed-off-by: Igor Matheus Andrade Torrente <***@gmail.com>
---
drivers/gpu/drm/drm_gem.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 000fa4a1899f..6e960d57371e 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -222,10 +222,10 @@ drm_gem_object_handle_put_unlocked(struct drm_gem_object *obj)
return;

/*
- * Must bump handle count first as this may be the last
- * ref, in which case the object would disappear before we
- * checked for a name
- */
+ * Must bump handle count first as this may be the last
+ * ref, in which case the object would disappear before we
+ * checked for a name
+ */

mutex_lock(&dev->object_name_lock);
if (--obj->handle_count == 0) {
--
2.20.1
Rodrigo Siqueira
2020-03-17 13:39:59 UTC
Permalink
Hi Igor,

First of all, thanks for your patch.

Just a few suggestions:
* Avoid using "Fix" in this sort of patch. Usually, we use "Fix" for
indicating a bug fix or similar. You can read more about it here:
https://kernelnewbies.org/PatchPhilosophy
* Patch subject format may vary between subsystem, however, I recommend
you to follow the instructions from this page:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

In summary, I just recommend you to improve the commit subject for your
V2.

Thanks
Post by Igor Matheus Andrade Torrente
Fix a checkpatch warning caused by a misaligned comment block.
---
drivers/gpu/drm/drm_gem.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 000fa4a1899f..6e960d57371e 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -222,10 +222,10 @@ drm_gem_object_handle_put_unlocked(struct drm_gem_object *obj)
return;
/*
- * Must bump handle count first as this may be the last
- * ref, in which case the object would disappear before we
- * checked for a name
- */
+ * Must bump handle count first as this may be the last
+ * ref, in which case the object would disappear before we
+ * checked for a name
+ */
mutex_lock(&dev->object_name_lock);
if (--obj->handle_count == 0) {
--
2.20.1
--
Rodrigo Siqueira
https://siqueira.tech
Igor Matheus Andrade Torrente
2020-03-17 20:11:09 UTC
Permalink
Fix a checkpatch warning caused by a misaligned comment block.

Signed-off-by: Igor Matheus Andrade Torrente <***@gmail.com>
---
drivers/gpu/drm/drm_gem.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 000fa4a1899f..6e960d57371e 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -222,10 +222,10 @@ drm_gem_object_handle_put_unlocked(struct drm_gem_object *obj)
return;

/*
- * Must bump handle count first as this may be the last
- * ref, in which case the object would disappear before we
- * checked for a name
- */
+ * Must bump handle count first as this may be the last
+ * ref, in which case the object would disappear before we
+ * checked for a name
+ */

mutex_lock(&dev->object_name_lock);
if (--obj->handle_count == 0) {
--
2.20.1
Loading...