Discussion:
[PATCH] thermal: hisilicon: Don't enable by default
(too old to reply)
Lubomir Rintel
2020-03-17 17:41:30 UTC
Permalink
Users are generally unlikely to have a HiSilicon thermal sensor.
Like most other thermal drivers, don't build it by default/

Signed-off-by: Lubomir Rintel <***@v3.sk>
---
drivers/thermal/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 02c3aa322a4a6..2062f8ec272b6 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -233,7 +233,6 @@ config HISI_THERMAL
depends on ARCH_HISI || COMPILE_TEST
depends on HAS_IOMEM
depends on OF
- default y
help
Enable this to plug hisilicon's thermal sensor driver into the Linux
thermal framework. cpufreq is used as the cooling device to throttle
--
2.25.1
Daniel Lezcano
2020-03-17 17:45:29 UTC
Permalink
Post by Lubomir Rintel
Users are generally unlikely to have a HiSilicon thermal sensor.
Why ?

The thermal sensor is needed for the thermal mitigation.
Post by Lubomir Rintel
Like most other thermal drivers, don't build it by default/
---
drivers/thermal/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 02c3aa322a4a6..2062f8ec272b6 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -233,7 +233,6 @@ config HISI_THERMAL
depends on ARCH_HISI || COMPILE_TEST
depends on HAS_IOMEM
depends on OF
- default y
help
Enable this to plug hisilicon's thermal sensor driver into the Linux
thermal framework. cpufreq is used as the cooling device to throttle
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Lubomir Rintel
2020-03-17 19:27:48 UTC
Permalink
Post by Daniel Lezcano
Post by Lubomir Rintel
Users are generally unlikely to have a HiSilicon thermal sensor.
Why ?
Because most computers don't run on HiSilicon chips.
Post by Daniel Lezcano
The thermal sensor is needed for the thermal mitigation.
If it's really needed, shouldn't ARCH_HISI depend on it?

In any case, I submitted this, because the driver enabled itself when I
turned on COMPILE_TEST, which was entirely unexpected. Unless I'm
mistaken, defaulting to off seems to be a standard practice for most
drivers, including thermal.

Would this be a better idea?

default y if ARCH_HISI

Thanks
Lubo
Post by Daniel Lezcano
Post by Lubomir Rintel
Like most other thermal drivers, don't build it by default/
---
drivers/thermal/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 02c3aa322a4a6..2062f8ec272b6 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -233,7 +233,6 @@ config HISI_THERMAL
depends on ARCH_HISI || COMPILE_TEST
depends on HAS_IOMEM
depends on OF
- default y
help
Enable this to plug hisilicon's thermal sensor driver into the Linux
thermal framework. cpufreq is used as the cooling device to throttle
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Daniel Lezcano
2020-03-17 20:05:33 UTC
Permalink
Post by Lubomir Rintel
Post by Daniel Lezcano
Post by Lubomir Rintel
Users are generally unlikely to have a HiSilicon thermal sensor.
Why ?
Because most computers don't run on HiSilicon chips.
Post by Daniel Lezcano
The thermal sensor is needed for the thermal mitigation.
If it's really needed, shouldn't ARCH_HISI depend on it?
In any case, I submitted this, because the driver enabled itself when I
turned on COMPILE_TEST, which was entirely unexpected.
The COMPILE_TEST option's contextual help says:

"If you are a developer and want to build everything available, say Y
here."
Post by Lubomir Rintel
Unless I'm
mistaken, defaulting to off seems to be a standard practice for most
drivers, including thermal.
The COMPILE_TEST option is there in order to increase the compilation
test coverage (for example compile the drivers on a powerful x86 machine
with different option combinations).
Post by Lubomir Rintel
Would this be a better idea?
default y if ARCH_HISI
Thanks
Lubo
Post by Daniel Lezcano
Post by Lubomir Rintel
Like most other thermal drivers, don't build it by default/
---
drivers/thermal/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 02c3aa322a4a6..2062f8ec272b6 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -233,7 +233,6 @@ config HISI_THERMAL
depends on ARCH_HISI || COMPILE_TEST
depends on HAS_IOMEM
depends on OF
- default y
help
Enable this to plug hisilicon's thermal sensor driver into the Linux
thermal framework. cpufreq is used as the cooling device to throttle
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Loading...